Skip to content

[Custom Errors] Add bandwidth warning for large custom error assets - #33298

Merged
mbullock1986 merged 1 commit into
productionfrom
docs-custom-errors-bandwidth
Sep 8, 2026
Merged

[Custom Errors] Add bandwidth warning for large custom error assets#33298
mbullock1986 merged 1 commit into
productionfrom
docs-custom-errors-bandwidth

Conversation

@mbullock1986

Copy link
Copy Markdown
Collaborator

Adds a caution note to the Custom Error Assets size limits section warning that large assets are served on every matching error and can generate significant egress traffic. Recommends keeping assets small and avoiding inlined large resources.

@mbullock1986
mbullock1986 requested review from a team and smarsh-cf as code owners September 8, 2026 12:11
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review

💡 1 suggestion found in commit 8fe1436.

👉 Fix in your agent 👈
Fix the following review findings in PR #33298 (https://github.com/cloudflare/cloudflare-docs/pull/33298).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Style Guide Review

### Suggestions (1)

#### SG-6fe168da3848 · Passive voice
- **File:** `src/content/docs/rules/custom-errors/index.mdx` line 106
- **Issue:** "a custom error asset is served to every visitor" and "external URLs are fetched and inlined as well" use passive voice; the actor (Cloudflare) is known and used as subject in the preceding clause
- **Fix:** Rewrite in active voice, e.g. "Cloudflare serves a custom error asset to every visitor that triggers the associated rule... Cloudflare inlines referenced resources when fetching the asset, and also fetches and inlines external URLs."

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

Suggestions (1)
File Issue
rules/custom-errors/index.mdx line 106 Passive voice — "a custom error asset is served to every visitor" and "external URLs are fetched and inlined as well" use passive voice; the actor (Cloudflare) is known and used as subject in the preceding clause Fix: Rewrite in active voice, e.g. "Cloudflare serves a custom error asset to every visitor that triggers the associated rule... Cloudflare inlines referenced resources when fetching the asset, and also fetches and inlines external URLs."
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/rules/ @maurizioabba, @mbullock1986, @smarsh-cf, @cloudflare/appsec-reviewers, @cloudflare/product-owners

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 8, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://docs-custom-errors-bandwidth.previews.developers.cloudflare.com (commit 8fe1436)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://76575b42.previews.developers.cloudflare.com 8fe1436 2026-09-08T16:40:03.354Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://65cc7392.previews.developers.cloudflare.com fbfdb93 2026-09-08T14:49:47.550Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://141b23d3.previews.developers.cloudflare.com 8d80cfc 2026-09-08T12:39:08.817Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://d0dc25a8.previews.developers.cloudflare.com eee5f15 2026-09-08T12:18:01.467Z Visit the dashboard ↗

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@mbullock1986
mbullock1986 enabled auto-merge (squash) September 8, 2026 12:36
@mbullock1986
mbullock1986 force-pushed the docs-custom-errors-bandwidth branch from 8d80cfc to fbfdb93 Compare September 8, 2026 14:33
@mbullock1986
mbullock1986 force-pushed the docs-custom-errors-bandwidth branch from fbfdb93 to 8fe1436 Compare September 8, 2026 16:25
@mbullock1986
mbullock1986 merged commit a88a0d0 into production Sep 8, 2026
16 checks passed
@mbullock1986
mbullock1986 deleted the docs-custom-errors-bandwidth branch September 8, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:rules Related to rules size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants